Re: [PATCH] mailer.py smtplib support

On Fri, Jan 10, 2003 at 02:18:23PM -0800, Matt Kraai wrote:
>...
> How about the following, which only sends mail if the to and from
> addresses are set?

I checked in a change (rev 4337); go take a look.

A hostname needs to be given to smtplib.SMTP() to actually have it connect
somewhere (or to call the .connect() method). I grabbed that hostname from
cfg.general.smtp_hostname. If that is defined, then the SMTP stuff is used.

It still isn't quite right, tho, as some headers need to be inserted for it
to look right (i.e. the "Author: gstein" is interpreted as a msg header
rather than part of the body).

Note that the test is: hasattr(cfg.general, 'foo') since it uses objects
rather than dictionaries.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org