[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

ooky bug I just filed...

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-01-10 22:57:33 CET

See: http://subversion.tigris.org/issues/show_bug.cgi?id=1083

The text is:

It is dreadfully easy to write a pre-commit hook that alters the text
of all the files being committed. The server then notifies the client
"committed. bump to rev NNN". The client then marks its copies of the
files with that new revision number.

The obvious problem here is that the client's copies of the files
don't match what was actually committed into repository. When the
client does an "update", they'll get a checksum error (or
pre-checksums, a diff that doesn't apply properly). If the client does
a commit, they'll get a checksum error or an invalid diff being applied.

Restoring the "resource walk" in the MERGE response would allow us to
send new checksums. It would also let us tell the client *everything*
that changed (for example, in the case where a pre-commit goes and
auto-tweaks a ChangeLog file). In fact, the server *was* telling the
client all the changes, but the client had a list of "these are the
things that I changed, I'm going to ignore the bump request if it
isn't on my list."

With the checksums in there, this isn't as bad as it could be, but it
is still pretty bad :-( We can also say "pre-commit should not modify
the txn", deferring that feature to post-1.0.

Not sure...


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 10 22:56:14 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.