Re: [PATCH] mailer.py smtplib support

On Thu, Jan 09, 2003 at 06:18:14PM -0800, Matt Kraai wrote:
> On Thu, Jan 09, 2003 at 05:57:56PM -0800, Greg Stein wrote:
> > It needs to be configurable, first and foremost. The script should be able
> > to continue generating to stdout, with optional smtp or pipe-to-MDA options.
>
> Configuration file options or command line options?

Configuration file. No command line options, please. Note that you'd
probably want to define an SMTP hostname, too.

In general, the patch looks good. Simpler than I expected, actually!

Oh, on the configuration, it is quite fine to just leave it as something
like "if an SMTP host is defined, then send the output there; otherwise,
just dump it to stdout". IOW, don't worry about "needing" to define all the
varieties. I think the most interesting part of your patch (actually get the
content sent as email) is the Goodness part to check in.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org