Re: progress report (for CMike)

cmpilato@collab.net wrote:

>Karl Fogel <kfogel@newton.ch.collab.net> writes:
>
>
>
>>Hey Mike, thought I'd post a State Of The Bunion for you before I went
>>to bed.
>>
>>
>
>[...]
>
>
>
>>#4 0x40046412 in svn_fs__retry_txn (fs=0x80779c8,
>> txn_body=0x400441fc <txn_body_rep_size>, baton=0xbffff3d0, pool=0x8066448)
>>
>>
>
>[...]
>
>
>
>>#9 0x40046412 in svn_fs__retry_txn (fs=0x80779c8,
>> txn_body=0x4004a7e8 <txn_body_apply_textdelta>, baton=0x80666e8,
>> pool=0x8066448) at subversion/libsvn_fs/trail.c:131
>>
>>
>
>Here's the first place to look. You're creating a new Berkeley txn
>while already inside one. I'm *pretty* sure you can't do that. I'll
>check this out on the trainride in.
>
>

Heh. You _can_ create nested transactions, but retry_txn doesn't do that
-- it creates a new top-level transaction. This can definitely lead to a
deadlock, even within the same process. How boring.

Seems to me that begin_trail should accept a parent_txn parameter to
create nested transactions.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org