Re: [PATCH] for some of issue #649

Karl Fogel wrote:

>+ struct apr_md5_ctx_t context;
>+ unsigned char digest[MD5_DIGESTSIZE];
>+
>+ /* Get a checksum digest for the empty string. */
>+ apr_md5_init (&context);
>+ apr_md5_final (digest, &context);
>

You're doing this in two separate places in the code. Why not just
calculate that checksum once, and use a statically initialized array?
It's not as if the MD5 algorithm is about to change.

$ python
Python 2.2.2 (#37, Oct 14 2002, 17:02:34) [MSC 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import md5
>>> m = md5.new()
>>> m.digest()
'\xd4\x1d\x8c\xd9\x8f\x00\xb2\x04\xe9\x80\t\x98\xec\xf8B~'

And there's your array initializer.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org