[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4236 - trunk/subversion/libsvn_client

From: Blair Zajac <blair_at_orcaware.com>
Date: 2003-01-03 06:17:51 CET

kfogel@tigris.org wrote:
>
> Author: kfogel
> Date: 2003-01-02 22:53:03 -0600 (Thu, 02 Jan 2003)
> New Revision: 4236
>
> Modified:
> trunk/subversion/libsvn_client/log.c
> Log:
> * subversion/libsvn_client/log.c
> (svn_client_log): Initialize err for the unlikely case that we have
> no targets at all. Thanks to Blair Zajac for noticing the
> uninitialized variable warning from GCC.
>
> Modified: trunk/subversion/libsvn_client/log.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/log.c (original)
> +++ trunk/subversion/libsvn_client/log.c Thu Jan 2 22:53:07 2003
> @@ -64,7 +64,7 @@
> const char *auth_dir;
> apr_array_header_t *condensed_targets;
> svn_revnum_t start_revnum, end_revnum;
> - svn_error_t *err;
> + svn_error_t *err = NULL; /* Because we might have no targets. */

On a pedantic note, but should that be SVN_NO_ERROR instead (which
is defined to 0)?

There's inconsistent usage throughout the code. Let me know and I can
make all usages consistent.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 3 06:18:00 2003

This is an archived mail posted to the Subversion Dev mailing list.