[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1039] Changed - ra_dav / svn cat : adds a blank line at start of file

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-24 04:12:08 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> It's also common to use /dev/tty for password prompts, in case input has
> been redirected (ssh does it, for instance, which is why you can use ssh
> with password authentication as an ra_svn tunnel agent). Perhaps we
> should do that, and send the echoed newline there as well.
>
> (That's Unix-specific, of course.)

Turns out apr_getpass() already does this (my comments in the issue
were wrong). It looks like we introduced the spurious newline in very
old commits in subversion/clients/cmdline/trace-commit.c (revisions
1.7 and 1.8).

That's from CVS days, and trace-commit.c is gone now, but maybe that
newline lives on somewhere. Diagnosing now...

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 24 04:53:51 2002

This is an archived mail posted to the Subversion Dev mailing list.