Re: [azverkan@yahoo.com: Joe Orton please read: Overrrun a neon buffer size during svn merge URL URL]

On Mon, Dec 23, 2002 at 06:59:44PM +0100, Johan Lindh wrote:
> >Thanks Johan. I took that, cleaned it up a bit, and extended it to map
> >the return values properly. Does the attached patch still work?
>
> Um, without actually testing it... from reading the code, it seems like
> set_strerror() will not now return an error message if the return value
> from WSAGetLastError() is unknown.

That's right, set_strerror doesn't return anything.

> More importantly, if ne_snprintf() takes a char * as it's first argument,
> then you're bashing the ne_socket structure with that call.
>
> Perhaps ne_snprintf( s->error, ..... ) was intended?

Good point - thanks. Updated patch attached.

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org