[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [azverkan@yahoo.com: Joe Orton please read: Overrrun a neon buffer size during svn merge URL URL]

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2002-12-23 17:57:36 CET

On Mon, Dec 23, 2002 at 03:39:10PM +0100, Johan Lindh wrote:
> On 2002-12-23 at 00:39 Joe Orton wrote:
> >The code in question is all inside neon's socket abstraction,
> >ne_socket.[ch] - only read_raw/write_raw/readable_raw should need
> >changing, it should be pretty clear what needs to be done.
>
> Unfortunately, ./configure from neon cvs bombs on my machine, so I couldn't test this properly.
> But anyway, here's a diff that at least does the minimum. That is, changes set_strerror() to
> a) write the Win32 error message and b) change the value of errno to something more reasonable.
>
> As is, the patch will not affect the return values in a consistent way, though, just the error message.
> If the read_raw() and others would call set_strerror() -before- checking the value of errno, the
> return value should get meaningful values on Win32 too.

Thanks Johan. I took that, cleaned it up a bit, and extended it to map
the return values properly. Does the attached patch still work?

Brandon, can you apply the attached patch (and undo the buffer size
change) then recompile neon/SVN and try your merge failure case? What
error message do you get now?

Regards,

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Dec 23 17:58:13 2002

This is an archived mail posted to the Subversion Dev mailing list.