[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] apr_dir_read doesn't return requested information

From: William A. Rowe, Jr. <wrowe_at_apache.org>
Date: 2002-12-18 04:58:32 CET

I'm sorry... this patch dir not come through to dev@apr for me today
(although I watched for it...) but it's simply WRONG.

At 07:04 PM 12/17/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote:
>>--- apr/file_io/unix/dir.c 15 Dec 2002 05:17:51 -0000 1.69
>>+++ apr/file_io/unix/dir.c 17 Dec 2002 00:49:35 -0000
>>@@ -218,10 +218,10 @@
>> return ret;
>> }
>>
>>-#ifdef DIRENT_INODE
>>+#ifndef DIRENT_INODE
>> wanted &= ~APR_FINFO_INODE;
>> #endif

Old logic; if we have an INODE from dirent, we don't care that we
want an INODE from stat() because we already have the INODE.

New Logic: if we don't have an INODE, we won't ask for an INODE
from stat().

I'm sorry, but that's just broken.
'
Please revert and (re)post the original description of the problem.

If you pass APR_FINFO_TYPE | APR_FINFO_INDOE | APR_FINFO_NAME
that is *ALL* you are promised... we do NOT stat for info you don't ask for.

Bill

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 18 05:03:23 2002

This is an archived mail posted to the Subversion Dev mailing list.