Re: [PATCH] Disallow going below root in svnserve - take two

Nuutti Kotivuori <naked@iki.fi> writes:
> Now when I took a peek, actually we use it in three places already -
> 'svnadmin', 'svnlook' and now 'svnserve'. So, yes, that should be in
> svn_error.h. But what should it be called, then? SVN_INT_ERR? I'm not
> sure I understand the original intent in the naming.

It handles an svn error then returns an integer error, right? So
SVN_INT_ERR is fine.

> No define - and the behaviour is almost the same. Error to stdout
> instead of stderr it seems, then the destruction of the pool and then
> return instead of an exit() call.

If you can convert that too, without changing the meaning, go for it.

> If there's a nice way to handle this all, someone could chime in and
> suggest it. But for the meantime, I'll put something like SVN_INT_ERR
> in svn_error.h and convert 'svnadmin' and 'svnlook' to using that.

Sounds good. Thanks for doing this!

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 18 01:36:44 2002