[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disallow going below root in svnserve

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2002-12-16 18:38:41 CET

Karl Fogel wrote:
> Nuutti Kotivuori <naked@iki.fi> writes:
>> It's a bit of a mess in my head which paths should be in which
>> format on a certain platform, and which paths should be in UTF-8
>> format with regarding ra_svn and which shouldn't.
>
> The rule is simply: paths going into, and coming out of, any `svn_*'
> interface must be UTF-8. Client applications must therefore convert
> from/to native encoding, but Subversion libraries shouldn't have to
> do recoding internally.

According to a discussion with &sussman; and &ghudson;, I'm think it's
finally clear to me.

Against the simple rule above, 'svn_repos_open' currently doesn't seem
to be expecting an UTF-8 path - atleast it isn't translating anything
to native. So, 'svn_repos_open' need to be fixed.

Then, svnserve's '-r' argument should be converted to UTF-8 before
passed onwards. This shouldn't probably be done before the above bug
is fixed.

Then we can just use 'apr_filepath_merge' on the paths. It's still a
bit unsure whether UTF-8 detranslation is needed before calling
'apr_filepath_merge' - it looks like it should handle UTF-8 paths, but
the translation is done in 'svn_path_get_absolute'.

So, did I miss anything?

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 16 18:39:38 2002

This is an archived mail posted to the Subversion Dev mailing list.