[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Setting email in hook scripts

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-12 17:29:21 CET

Gustavo Niemeyer <niemeyer@conectiva.com> writes:
> I'm sorry. I was just suprised to see so many reactions and suggestions
> to redo such a simple patch in different ways. By the time of Blair's
> message, I wasn't even sure if this patch was going to be accepted with
> "-f" or I'd have to change to "--from" or something like that. It's my
> intention to save you as much time as possible. OTOH, I'd also
> appreciate any tentatives of saving my own scarce time.

Understood, but remember that for every one patch submitter, there are
many, many patch reviewers. So we try to optimize the process to the
needs of the many.

> As a symbol of my good will, and appreciation of your work, here is the
> latest version of the patch, including Blair's alphabetical code
> reordering suggestion, and a copy of the first log:

Thank you!

> This patch allows one to set the complete 'From:' address on hook
> scripts. This is very useful in places where there's no way to
> simply append the subversion username to some hostname.
> * hook-scripts/commit-email.pl
> * hook-scripts/propchange-email.pl
> Include new -f option which, if set, will override the -h option
> and set the email 'From:' to whatever is provided as the option
> argument.

Okay. By the way, yes, I'm pretty convinced it should be a long
"--from" option, but obviously if you don't have time to rework the
patch, then the reviewer/applier can take care of it. However, if you
are already familiar with the option parsing code, it might be fast
for you to do it; just let us know either way.

+1 on the general change, of course.

I've got a medium-sized list of saved patches to go through right now;
I'll start reviewing them. Any that are trivial to apply, I'll apply
right away, the rest I'll create `PATCH' issues for.

Thanks for your patience,

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 12 18:09:14 2002

This is an archived mail posted to the Subversion Dev mailing list.