Re: svn commit: rev 4094 - in trunk/subversion: include libsvn_wc clients/cmdline

Peter Davis <peter@pdavis.cx> writes:

> On Wednesday 11 December 2002 13:49, sussman@tigris.org wrote:
> > Fix issue #714. If 'svn revert' attempts to revert a missing
> > directory, then send a new "failed revert" notification to the client.
> > Our commandline client interprets this signal by recommending an update.
>
> I think this fix breaks the fix committed in r3614 (see
> http://subversion.tigris.org/issues/show_bug.cgi?id=863). Does it pass the
> test committed in that same revision?

Absolutely! I always run 'make check' before committing. And I just
reverified that test passes. Maybe it doesn't have the coverage we
need. :-)

>
> $ svn mkdir foo
> $ rm -rf foo
> $ svn revert foo
> [fails with the new error]

Drat and double-drat.

I don't understand this: before my change, the missing dir didn't
actually get reverted, did it? I thought the command was just dying
silently.

> $ svn up foo
> [fails hard, and locks the wc]
> $ svn revert .
> [fails because wc is locked]
> $ svn st
> L .
> ! foo
> $ svn cleanup .
> [fails because it can't unlock foo]

Investigating and fixing now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 12 00:44:44 2002