Re: [PATCH] Setting email in hook scripts

Gustavo Niemeyer <niemeyer@conectiva.com> writes:
> > Also, a log message as described in HACKING would be useful.
>
> Is there any problem with the log message I sent in the first message?

At this point, there are multiple patches floating around, and a log
message, in an old email, that may or may not apply to all of the
patches.

By including a log message with each posting of the patch, you save
reviewers time, because they won't have to hunt around old mails
looking for a log message (and then wonder, when they find it, whether
it's still up-to-date).

But I think a more general answer is: try to imagine yourself as a
potential reviewer, and ask yourself "What would make my life easier?"

So, can you repost with:

  a) the log message for the latest version of the patch
  b) the latest version of the patch

and save us all some confusion? :-)

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 11 22:49:21 2002