Re: Are COMPILE_SWIG_PY & COMPILE_SWIG_JAVA used any more

Blair Zajac <blair@orcaware.com> writes:

> Is COMPILE_SWIG_PY and COMPILE_SWIG_JAVA used any more? A
> recursive grep shows only these two locations and no uses of
> it:
>
> % rgrep COMPILE_SWIG_PY|grep -v /.svn
> ./Makefile.in: COMPILE_SWIG_PY = $(LIBTOOL) $(LTFLAGS) --mode=compile $(CC) $(CPPFLAGS) -DSWIGPYTHON $(CFLAGS) $(SWIG_PY_INCLUDES) $(INCLUDES) -o $@ -c $<
> ./build/gen_make.py: self.ofile.write('%s: %s\n\t$(COMPILE_SWIG_PY)\n' % (obj, src))
>
> % rgrep COMPILE_SWIG_JAVA | grep -v /.svn
> ./Makefile.in: COMPILE_SWIG_JAVA = $(LIBTOOL) $(LTFLAGS) --mode=compile $(CC) $(CPPFLAGS) -DSWIGPYTHON $(CFLAGS) $(SWIG_JAVA_INCLUDES) $(INCLUDES) -o $@ -c $<
> ./build/gen_make.py: self.ofile.write('%s: %s\n\t$(COMPILE_SWIG_JAVA)\n' % (obj, src))
>
> Can these be removed?
>
> They sure look useful for building the Swig bindings, but I'm
> guessing we moved away from this build method?

I just introduced COMPILE_SWIG_JAVA, attempting to mirror what
COMPILE_SWIG_PY does. They are both Makefile variables filled in by
the configure script (by way of m4 macros) which contain the target
bodies for the rules generated by gen_make.py:

subversion/bindings/swig/swigutil_py.lo: subversion/bindings/swig/swigutil_py.c
        $(COMPILE_SWIG_PY)

subversion/bindings/swig/swigutil_java.lo: subversion/bindings/swig/swigutil_java.c
        $(COMPILE_SWIG_JAVA)

So no, I don't think they can go. Perhaps their usage could be
clarified somehow?

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org