[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn-fast-time-from-cstring.patch

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-12-11 15:45:31 CET

Brandon Ehle wrote:

> Branko Čibej wrote:
>
>> Isn't this a repost of your earlier patch? I thought we'd applied
>> that one.
>>
>>
> I believe it had been rejected because my editor went a little nuts
> with beautification.

Ah. I remember now. I had hoped you'd repost the patch without the
unnecessary reformatting. This seems to be it. Well, it's not entirely
in the same format as the rest of the file, but upon looking at the code
I see that svn_time_from_cstring is inconsistent already. "A foolish
consistency is the hobgoblin of small minds."

+1, I say it should go in.

And, for the record, I propose we kill that
space-before-parein-in-function-call rule.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 11 15:46:17 2002

This is an archived mail posted to the Subversion Dev mailing list.