[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Setting email in hook scripts

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-12-11 00:33:56 CET

Gustavo Niemeyer wrote:
>
> > What would you say about re-submitting using -f (for "from address")
> > instead of -e? "email" is quite ambiguous.
>
> You're right. Here is an updated patch. Thank you!

Minor nit. Can you keep the options in alphabetical order, in the
lines:

> + if (my ($opt) = $arg =~ /^-([hflmrs])/)
> my %opt_to_hash_key = (h => 'hostname',
> + f => 'from_addr',
> l => 'log_file',

Also, a log message as described in HACKING would be useful.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 11 00:34:54 2002

This is an archived mail posted to the Subversion Dev mailing list.