[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disallow going below root in svnserve

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-12-09 18:04:06 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> I looked at the win32 apr_filepath code and it looks like it can deal
> with '/' separators, but I don't know how guaranteed that is.

APR supposedly uses '/' on all platforms, so I would think if this
doesn't work, it's a bug in APR that we should fix.

> I'm starting to become convinced that src_err should just go away. When
> you're looking at an error structure, you don't know what namespace
> src_err lives in (the comment claims it might be an "errno, h_errno,
> etc."). handle_error does nothing with it.

+1. It's almost always zero in our calls.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 9 18:43:05 2002

This is an archived mail posted to the Subversion Dev mailing list.