[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 1027

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-12-08 23:03:08 CET

On Sunday, December 8, 2002, at 02:10 PM, rotering@animalcules.com
wrote:

>> From the description of issue 1027:
>
> file: subversion/clients/cmdline/util.c
> line: 447
> function: svn_cl__get_log_message
>
> msg2 is never set to NULL and if svn_cl__get_log_message fails
> msg2 is
> not effected. A more appropriate check would be if(!err)
>
> Initializing msg2 to NULL would fix this problem as well as a similar
> one on line 476.
>
> Just to clarify the effect of this bug:
>
> If svn_cl__edit_externally() on line 445 fails and msg2 happens to be
> nonzero (because it's uninitialized) the call to strlen on line 455
> raises SIGSEGV.

it sure looks like a bug to me.

how about putting together a patch and a log message for it? i'll be
happy to review and commit it for you.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 8 23:03:58 2002

This is an archived mail posted to the Subversion Dev mailing list.