Re: Heads up: config option name changes

Greg Hudson <ghudson@MIT.EDU> writes:

> On Fri, 2002-12-06 at 13:02, Daniel Rall wrote:
> > Any thoughts on renaming this to something like http-proxy-ignores or
> > http-proxy-exceptions to use a uniform namespace?
>
> I thought about it briefly and didn't come up with a good name. But
> http-proxy-exceptions sounds fine. But I think I will let someone else
> commit that change if they agree that it's a good idea.

I will commit this if no one voices any clarifictions or objections.

* subversion/libsvn_subr/config_file.c
    (svn_config_ensure): Renamed no-http-proxy configuration parameter
    to http-proxy-exceptions.

* subversion/libsvn_ra_dav/session.c
    (get_server_settings): Renamed no-http-proxy configuration parameter
    to http-proxy-exceptions.

Index: subversion/libsvn_subr/config_file.c
===================================================================
--- subversion/libsvn_subr/config_file.c (revision 4031)
+++ subversion/libsvn_subr/config_file.c (working copy)
@@ -687,10 +687,10 @@
         "### any other sections.\n"
         "### \n"
         "### If you go through a proxy for all but a few sites, you can\n"
- "### list those exceptions under `no-http-proxy', see below. This\n"
- "### only overrides defaults, not explicitly matched proxies.\n"
+ "### list those exceptions under `http-proxy-exceptions', see below.\n"
+ "### This only overrides defaults, not explicitly matched proxies.\n"
         "# [default]\n"
- "# no-http-proxy = *.exception.com, www.internal-site.org\n"
+ "# http-proxy-exceptions = *.exception.com, www.internal-site.org\n"
         "# http-proxy-host = defaultproxy.whatever.com\n"
         "# http-proxy-port = 7000\n"
         "# http-proxy-username = defaultusername\n"
Index: subversion/libsvn_ra_dav/session.c
===================================================================
--- subversion/libsvn_ra_dav/session.c (revision 4031)
+++ subversion/libsvn_ra_dav/session.c (working copy)
@@ -156,7 +156,7 @@
 
   /* If there are defaults, use them, but only if the requested host
      is not one of the exceptions to the defaults. */
- svn_config_get(cfg, &exceptions, "default", "no-http-proxy", NULL);
+ svn_config_get(cfg, &exceptions, "default", "http-proxy-exceptions", NULL);
   if ((! exceptions) || (! svn_cstring_match_glob_list(requested_host,
                                                        exceptions, pool)))
     {

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org