[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4012 - trunk/subversion/libsvn_client

From: <cmpilato_at_collab.net>
Date: 2002-12-05 20:07:27 CET

cmpilato@collab.net writes:

> > That wacky pool usage was on purpose.
> >
> > harvest_committables itself is executed in a loop many times (think of
> > the recursive case).
>
> And the pool handing to it in those looping cases is itself a subpool
> that gets cleared per-iteration. The effects of my change were to go
> from:
>
> while ()
> begin harvest_committables
> make subpool
> use subpool
> destroy subpool
> end harvest_committables
>
> to:
>
> while ()
> make subpool
> begin harvest_committables
> use subpool
> end harvest_committables
> destroy subpool
>
> which is how we typically expect pool usage in Subversion to work.

I did just notice that one instance of a loop around
harvest_committables() is not using an iteration pool. Fixing that
now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 5 20:10:55 2002

This is an archived mail posted to the Subversion Dev mailing list.