[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Bug: Control char in commit message

From: John Barstow <John_Barstow_at_gfsg.co.nz>
Date: 2002-12-05 00:54:16 CET

> Look at libsvn_subr/xml.c:xml_escape, Subversion currently escapes the
> five characters &<>"'. In particular it doesn't escape the ^H that
> Andreas used. I find it odd that Subversion "escapes" a different set
> of characters from that "quoted" by apr_xml_quote_elem, but then I
> don't know much about XML or UTF8.

The five characters are the ones that need to be escaped. ^H and other
control characters aren't escaped because they're not valid in XML (I stress
that they *are* valid UTF-8, just *not* valid XML). There is no defined
escape sequence for invalid characters.

What needs to happen in or before xml_escape is a check for invalid
characters per the XML definition, followed by escaping the five characters.

John C Barstow

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 5 00:48:57 2002

This is an archived mail posted to the Subversion Dev mailing list.