[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3973 - trunk/subversion/tests/libsvn_delta

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-12-04 19:22:40 CET

Matt Kraai wrote:

>On Tue, Dec 03, 2002 at 06:50:17PM -0600, brane@tigris.org wrote:
>
>
>>Author: brane
>>Date: 2002-12-03 18:50:17 -0600 (Tue, 03 Dec 2002)
>>New Revision: 3973
>>
>>Modified:
>> trunk/subversion/tests/libsvn_delta/random-test.c
>>Log:
>>This is fallout from my deciding not to have admin privs for my normal
>>login on the new Windows box...
>>
>>* subversion/tests/libsvn_delta/random-test.c: Don't use tmpnam to
>> open temporary files.
>>(open_temp, close_temp): New functions. Use instead of tmpfile and
>>fclose, respectively.
>>(unlink_magic_struct): Helper for close_temp to maintain the list of
>>open file names.
>>
>>
>
>This use of tempnam is insecure.
>
Why should I care about that in a test program? This code is not part of
the Subversion libraries.

>Would you use apr_file_mktemp instead?
>
No, because then I'd have to rewrite all of random-test.c to use APR
files instead for STDIO files, and I can't be bothered.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 19:23:43 2002

This is an archived mail posted to the Subversion Dev mailing list.