[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] (2) Improve performance of svn_time_from_cstring

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-12-04 01:00:33 CET

Brandon Ehle wrote:

> * subversion/libsvn_subr/time.c (svn_time_from_cstring): Replace
> sscanf with strtoul for better performance.

[snip]

>- exploded_time.tm_wday = find_matching_string (wday, 7, apr_day_snames);
>- exploded_time.tm_mon = find_matching_string (month, 12, apr_month_snames);
>+ exploded_time.tm_wday = find_matching_string(wday, 7, apr_day_snames);
>+ exploded_time.tm_mon = find_matching_string(month, 12, apr_month_snames);
>
You're changing the formatting style here. Please don't do that. The
rules are: 1) Follow the style the rest of the file uses, and 2) Don't
mix formatting-only changes with functional changes.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 01:01:10 2002

This is an archived mail posted to the Subversion Dev mailing list.