[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3964 - in trunk: . subversion subversion/libsvn_ra subversion/include subversion/tests/clients/cmdline/getopt_tests_data subversion/libsvn_ra_svn subversion/svnserve

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-12-03 11:36:09 CET

On Mon, Dec 02, 2002 at 09:55:50PM -0600, ghudson@tigris.org wrote:
>...
> Modified:
> trunk/build.conf
> trunk/configure.in

-1

This code should not be part of the default build (for now) for a couple
reasons:

* the socket stuff needs to be apr-ized
* this code has never been seen before; 150k is a *huge* amount of code to
  appear from nowhere and suddenly become part of the build

At first glance, the code appears quite good, as would be expected from Greg
Hudson. But the non-apr-ized socket stuff is a problem, and I have serious
issues with huge commits that nobody has ever seen before. I don't think
that is a very good precedent, for anybody, no matter how good the code may
or may not be.

I've semi-reverted (commented out) the build.conf and configure.in changes.
The rest can stay in; I've got no problems there. But this shouldn't be part
of the default build right now. Give it some time and discussion and
apr-izing first.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 3 11:34:28 2002

This is an archived mail posted to the Subversion Dev mailing list.