[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: new mem-management for libsvn_fs?

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-10-31 23:14:46 CET

Ben Collins-Sussman <sussman@collab.net> writes:
> * every txn_body() routine changes signature:
>
> * txn_body(baton, trail) ==> txn_body(baton, trail, returnpool)
>
> * txn_body routines continue to let fs routines use trail->pool
> for both scratchwork and return-data as usual, but before
> exiting, makes *copies* of important data into the returnpool.
>
> * retry_txn() simply passes the main caller pool as the
> 'returnpool' to the txn_body routine.
>
> * commit_txn() destroys trail->pool upon exit.
>
> ==> only return-data is preserved; all scratchwork is freed.

This sounds so sane, I could eat my socks.

> The real work here is going through every single txn_body_ routine,
> and teaching it to make 'deep' copies of return-data into the return
> pool. Before I start this, I want Old Hundred Eyes to agree that this
> is a good approach. :-) cmpilato and I think it's the way to go.

These two eyes are crying with joy :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 31 23:46:23 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.