Re: svn commit: rev 3576 - clients/gsvn/trunk/src

On Wed, Oct 30, 2002 at 02:54:41AM -0600, cmpilato@tigris.org wrote:
>...
> +++ clients/gsvn/trunk/src/gsvn_wc.py Wed Oct 30 02:54:40 2002
>...
> + debug_stuff = str([kind, mime_type, states[content_state],
> + states[prop_state], revision])
> + print "%s %s : %s" % (actions[action], path, debug_stuff)

The %s format modifier will, effectively, call str() on the argument then
insert the resulting string. Thus, the str() for debug_stuff is redundant.

>...
> + cmt_info = _client.svn_client_commit (notify_fn,

This function call style is never used in Python.

[ well, maybe in some blasphemous code like distutils, but hey... :-) ]

>...
> + def mkdir(self, nodes):
> +
> + subpool = _util.svn_pool_create(self.pool)
> + for n in nodes:
> + _client.svn_client_mkdir(n, self.auth_baton,
> + None, notify_fn, subpool)
> + _util.apr_pool_destroy(subpool)
> +
> + def delete(self, nodes,
> + force=0):
> +
> + subpool = _util.svn_pool_create(self.pool)
> + for n in nodes:
> + _client.svn_client_delete(n, None, force, self.auth_baton,
> + None, notify_fn, subpool)
> + _util.apr_pool_destroy(subpool)

If you're creating an iteration subpool, don't you want to clear it?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org