[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3569 - trunk/build

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-10-31 10:52:01 CET

On Tue, Oct 29, 2002 at 10:42:07PM -0600, brane@tigris.org wrote:
>...
> +++ trunk/build/getversion.py Tue Oct 29 22:42:06 2002
> @@ -31,6 +31,7 @@
> except:
> continue
> setattr(result, name, int(match.group(2)))
> + stream.close()
> return result

Bah. It gets closed at that 'return' statement. As soon as 'stream' goes out
of scope, the refcount hits zero, and the file is closed.

That said, I'd mark it down to personal style. I never do it because it just
adds wordiness to the code. Others may want to do it for explictness.

*shrug*

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 31 10:51:40 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.