Re: Subversion 0.14.4 released

Branko ?ibej wrote:
>
> Philip Martin wrote:
>
> >The top of ac-helpers/berkeley-db.m4 sets status to "required", then
> >when the test fails the following code in ac-helpers/berkeley-db is
> >run
> >
> > case "$found" in
> > "not" )
> > if test "$status" = "required"; then
> > AC_MSG_ERROR([Could not find Berkeley DB $1.$2.$3. with libname $4])
> > fi
> > svn_lib_berkeley_db=no
> > ;;
> >
> >
> >I think AC_MSG_ERROR must be fatal, I don't know much about autoconf,
> >but if I put an echo immediately after the AC_MSG_ERROR its output
> >doesn't appear.
> >
> Yes, of course it's fatal.
>
> >So I think it affects BDB 4.0 as well as 4.1, this will affect lots of
> >people. Perhaps we should pull the 0.14.4 tarball?
> >
> >
> I agree absolutely. In the meantime, Ben, please try the attached patch.
> It moves the logic for testing several lib names from configure.in to
> SVN_LIB_BERKELEY_DB in ac-helpers/berkeley-db.m4.
>

There's an expansion issue with the patch with the $4 in the macro.
It's passing "db4 db" as $4 and the

      for db_libname in $4; do

ends up as

      for db_libname in "db4 db"; do

which of course doesn't separate the library names and you end up with
this:

checking for Berkeley DB in /opt/i386-linux/db-4.1 (as db4 db)... no

Change

+ $SVN_FS_WANT_DB_PATCH, "db4 db")

to

+ $SVN_FS_WANT_DB_PATCH, [db4 db])

Also, I'm on RedHat 8 and installed a vanilla DB 4.1.24 and it installs
db into libdb-4.1, which isn't found by default.

How about changing this to

+ $SVN_FS_WANT_DB_PATCH, [db-4.1 db-4.0 db-4 db4 db])

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org