Re: [PATCH] Do 'svn log --xml --incremental'

Nuutti Kotivuori <naked@iki.fi> writes:

> > I'd wait until after the tarball,
>
> Actually, it's already committed.

Yah, I saw that after I mailed.

> > but I have some questions about the patch. It looks like depending
> > on the way you run the program, you get different DTD compliance. I
> > think you should just lose the <log></log> items altogether, and
> > simply have the collection of <logentry> items. --incremental would
> > do nothing different except omit the <?xml> tag.
>
> Um, it's not a well-formed XML document if there are several
> root-level elements. And if the output isn't entirely well-formed,
> there is no reason to output the XML declaration either.

Oh yeah, that's right. Sorry, forgot about that.

> So - I could go for dropping the --incremental option altogether and
> have the default output only have <logentry> items always. People can
> do their own wrapping if they want it as a well-formed document just
> as well. Would you consider this as a better choice?

Hm... that might work. I dunno. I admit this isn't something I'm
likely to myself use, so perhaps my opinion is uninteresting.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 29 23:33:46 2002