Nuutti Kotivuori <naked@iki.fi> writes:
> Nuutti Kotivuori wrote:
> > Just a quick review before commit, because it's been ages since I
> > last committed anything.
> >
> > Log message:
> > Taught the xml log output to take advantage of the new --incremental
> > option that was added.
>
> Since you guys seem to be doing tarball right now, I'm a bit unsure
> what to do with this. The change seems fine and tests pass - but I
> don't know whether I should commit it right now or later on or even if
> it matters any.
I'd wait until after the tarball, but I have some questions about the
patch. It looks like depending on the way you run the program, you
get different DTD compliance. I think you should just lose the
<log></log> items altogether, and simply have the collection of
<logentry> items. --incremental would do nothing different except
omit the <?xml> tag.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 29 22:43:10 2002