brane@tigris.org writes:
> * subversion/libsvn_subr/io.c (svn_io_copy_file): Disable permission copying
> on Windows, as it was before r3484.
Shouldn't we maybe
1. Fix the documentation in apr/include/apr_file_io.h to indicate
that apr_file_info_get() can return APR_INCOMPLETE
and possibly:
2. Check for that APR_INCOMPLETE in the copy_perms!=0 case in
svn_io_copy_file()
?
In any case, the comment added in this change is a bit misleading.
svn_io_copy_file() no longer asks apr_file_copy() to copy perms, so
the only issue here is with apr_file_info_get().
-Karl
> Modified: trunk/subversion/libsvn_subr/io.c
> ==============================================================================
> --- trunk/subversion/libsvn_subr/io.c (original)
> +++ trunk/subversion/libsvn_subr/io.c Sun Oct 27 15:45:15 2002
> @@ -211,6 +211,14 @@
> const char *src_native, *dst_native;
> const char *dst_tmp;
>
> +#ifdef SVN_WIN32
> + /* ### FIXME: apr_file_copy with perms, or anything that expects
> + that apr_file_info_get with APR_FILE_PROT will never return
> + APR_INCOMPLETE, may fail on Win32. We need a platform-specific
> + implementation to get the permissions right. */
> + copy_perms = FALSE;
> +#endif
> +
> SVN_ERR (svn_utf_cstring_from_utf8 (&src_native, src, pool));
> SVN_ERR (svn_utf_cstring_from_utf8 (&dst_native, dst, pool));
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 28 06:25:23 2002