Karl, your r3484 chante to io.c:svn_io_copy_file...

...breaks the Win32 tests badly. Why did you ignore (and remove) the
Win32-specific warning in the comment there?

I really don't understand what you're trying to achieve with copying
permissions after the rename. On Unix, a rename preserves permisions, as
long as it's within the same device -- as this rename is, being in the
same directory. So you could just tell apr_file_copy to copy permissions
to the temporary file, and then rename it. In fact, the way things stand
now, the permission copying is _not_ atomic, so your comment in the log
message is misleading.

For now, I'll disable the copy_perms flag on Windows, so that I can run
the test, and put that warning back, so that people don't forget about
the issue. We can decide about a real solution after we've discussed
this a bit more.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org