cmpilato@tigris.org writes:
> Author: cmpilato
> Date: 2002-10-25 02:23:07 -0500 (Fri, 25 Oct 2002)
> New Revision: 3495
>
> Modified:
> trunk/subversion/clients/cmdline/util.c
> Log:
> Haha. My last change was actually fine, but since I had the special
> EOF text in the body of my log, and that text wasn't at the beginning
> of a line, it trigger a different bug. I'll put that text in this log
> message right about "--This line, and those below, will be ignored--"
> here and see if this new fix takes care of that problem.
>
> * subversion/clients/cmdline/util.c
> (truncate_buffer_at_prefix): Don't give up the hunt for 'prefix'
> just because the one you found didn't start in column 0.
>
> There is magic text below this line that should get removed by my -F commit.
That's more like it.
I'm sure *someone* is going to wonder why I didn't solve issue #761 by
stripping the extra gunk off the commit message and then re-writing it
to disk in the event of a failure. I'll go ahead and answer that:
1. performance - if we have to open a tmp file for the editor to
use, we might as well just keep the file around instead of
reading its results, trimming those results of the gunk,
removing the file, and then potentially creating a whole new
file and dumping the log into it.
2. if we're having to keep this log message around, it's because of
some error condition. as your program is trying to breathe its
last breath and tell you, "i'm sorry sir, but ... i've failed
you" is *not* a good time to start up a complex task like doing
a bunch of file i/o. :-)
Am I tied to this solution versus something else? Not a bit. If you
have a better plan, the code is aaaaaall yours. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 25 09:49:17 2002