Re: [PATCH] cvs2svn.py (1/2): infrastructure/options

Quoting Greg Stein <gstein@lyra.org>:

> On Thu, Oct 24, 2002 at 11:50:14PM +0200, Branko Cibej wrote:
> >...
> > >+def branch_path(ctx, branch_name = None):
> > >+ if branch_name == None:
> >
> > Minor nit: None is a unique object, so you can/should test with "is"
>
> > rather than "==". This is not a showstopper, though.
>
> Drop the test altogether (and reverse the blocks):
>
> if branch_name:
> whatever...

Huh, of course...

> > +1 for applying options.dff and usagectx.diff (should be applied on top
> > of the former, right?). Greg, any objections?
>
> +1 ... looks great!

Committed in r3492. Thanks, Mark!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 25 08:26:26 2002