Re: [PATCH] cvs2svn.py (1/2): infrastructure/options

Marko Macek wrote:

> Hi!
>
> ChangeLog:
> - added --trunk, --tags and --branches command line options for
> specifying relative repository paths
> - changed the default behavior to import into an existing repository
> - added a command line option --create for creating a new repository
> - added infrastructure for handling branches
>
> Regards,
> Mark
>
>------------------------------------------------------------------------
>
>--- ../../cvs2svn/cvs2svn/cvs2svn.py 2002-10-23 06:27:10.000000000 +0200
>+++ ./cvs2svn.py 2002-10-24 20:21:41.000000000 +0200
>@@ -140,6 +140,12 @@
> self.revs.write('%08lx %s %s %s %s\n' % (timestamp, digest,
> op, revision, self.fname))
>
>+def branch_path(ctx, branch_name = None):
>+ if branch_name == None:
>
Minor nit: None is a unique object, so you can/should test with "is"
rather than "==". This is not a showstopper, though.

+1 for applying options.dff and usagectx.diff (should be applied on top
of the former, right?). Greg, any objections?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org