[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: regression tests failing over ra_dav

From: <cmpilato_at_collab.net>
Date: 2002-10-24 04:30:58 CEST

Philip Martin <philip@codematters.co.uk> writes:

> svn_ra_dav__get_file calls filter_props, which calls
> set_special_wc_prop, which uses add_prop_to_hash to put
> svn_stringbuf_t pointers into the hash. Looks like rev 3459 is the
> culprit.

Culprit? I'm offended. My change merely revealed an existing bug
that we were lucky to get away with because the data and len members
of svn_string_t's and svn_stringbuf_t's fell in the right places. The
interfaces for ra->get_file and get_dir state that the hash has
string_t's in it ... add_prop_to_hash() was clearly violating that.

Either way, I'm on the fix to the *real* culprit now...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 24 04:32:47 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.