Re: [PATCH] Support both BDB 4.0 and 4.1

Philip Martin wrote:

>Branko ÄŒibej <brane@xbc.nu> writes:
>
>
>
>>Here's a second version of this patch, slightly cleaned up. I moved
>>svn_bdb__check_version into its own file, and I realised there's no
>>need to remember the compile-time DB version in static variables --
>>those defines are constants, anyway. I also reverted the include of
>>bdb_compat.h from the headers that didn't use any of its features.
>>
>>
>
>The .dsp bit didn't apply, but what do I care about that gooey stuff :)
>
>It still doesn't work over ra_dav, I've built BDB 4.1 with debug so I
>now know exactly where it's failing:
>
[snip gdb-fu]

>The relevant BDB code is
>
> if (!TXN_ON(dbenv)) {
> __db_err(dbenv,
> "DB_AUTO_COMMIT may not be specified in non-transactional environment");
> return (EINVAL);
> }
>
>
>The AUTO_COMMIT flag is added by vt_db_open in apr_dbm_open.c.
>

Aha! That's an APR bug, then. It's not passing DB_INIT_TXN to
DB_:ENV->open; compare with libsvn_fs/fs.c:494. In fact, APR doesn't
seem to be opening an environment at all, si I suspect it shouldn't be
using DB_AUTO_COMMIT. Well, duh.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org