<brane@xbc.nu> writes:
> B. W. Fitzpatrick wrote:
>
> >>* subversion/tests/clients/cmdline/commit_tests.py:
> >> (commit_one_new_binary_file): Remove underbars from status checks.
> >> (test_list): Remove XFAIL from commit_one_new_binary_file as it now
> >> passes (Referenced in issue 888)
> >>
> >>
> >
> >Brane,
> >
> >This defun had no doc string, so I checked the log, saw the 888 ref
> >and looked it up in issuezilla, and it's RESOLVED. Can you verify that
> >I got this right (and maybe add in a docstring)?
> >
> >
>
> There's not much to say about that test. I added to check that issue,
> but it looks like the test was broken anyway (the expected status was
> wrong -- the underscore was missing). Since that's fixed, and the test
> is passing, it's perfectly O.K. to remove the XFAIL. I'm not sure what
> sort of docstring you expect me to add there, though.
I just didn't understand exactly what you were testing for. It's fine
as is.
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 20 23:01:38 2002