Re: diffs & removed directories

Gustavo Niemeyer <niemeyer@conectiva.com> writes:

> That happens because in libsvn_repos/delta.c:delta_dirs(), delete()
> is called for each entry in the source path that doesn't exist in
> the target path. OTOH, the editor function
> libsvn_client/repos_diff.c:delete_entry() simply checks the path kind,
> and forwards the call to the libsvn_client/diff.c:diff_dir_deleted()
> diff callback function, which does nothing.
>
> IMO, delete_entry() should be changed to recurse into the directory
> and call itself recursivelly for each entry, if recursion is enabled.

I'm not sure that's the right thing to do, it would affect more than
diff, for example it would also affect update. Look at the function
diff_dir_deleted in libsvn_client/diff.c, I think the plan is to call
RA->get_dir (which didn't exist when the diff editor was written) to
get a separate report for the deleted directory.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org