Re: [PATCH] test import of executable separately from basic import

Brian Denny wrote:

>the only issue i can think of with this patch is:
>- maybe "basic_import_executable" shouldn't be in "basic_tests.py"?
> should it go in commit_tests.py instead?
>
>in spite of my problems running the tests on windows, the particular
>tests that this patch touches run correctly for me both before and after
>applying the patch.
>
Incidentally, what happens if you run the tests on the Release build
(python win-tests.py r)?

>patch attached, log follows.
>
>-brian
>
>Log:
>
>Split test "basic_import" into two tests: "basic_import", which
>is run on all platforms, and "basic_import_executable", which
>is SKIPped on non-posix platforms.
>
>* subversion/tests/clients/cmdline/basic_tests.py
> - added test 'basic_import_executable'
> - pared down 'basic_import' to simpler, platform-neutral functionality
>
BTW, the patch seems fine, except for one thing: I'd like to factor out
the open(foo)/close pairs that create a new file. I wonder if we don't
have a set-file-contents utility function somewhere; if we don't, we
should. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org