Re: "M_" in status

>>>>> On Thu, 17 Oct 2002 14:04:51 +0200, Rafael Garcia-Suarez <raphel.garcia-suarez@hexaflux.com> said:

> andreas.koenig@anima.de (Andreas J. Koenig) wrote:
> ...
>> Index: subversion/clients/cmdline/status.c
>> ===================================================================
>> --- subversion/clients/cmdline/status.c
>> +++ subversion/clients/cmdline/status.c Thu Oct 17 09:39:21 2002

> While you're at it, I also notice this inaccurate comment in status.c
> for the svn_cl__generate_status_codes() function :

> This function is also used by commit-cmd.c

> (this function appear to be used only in status.c. Turn it into static ?)

You mean like so?

Index: subversion/clients/cmdline/main.c
===================================================================
--- subversion/clients/cmdline/main.c
+++ subversion/clients/cmdline/main.c Thu Oct 17 10:05:13 2002
@@ -383,7 +383,7 @@
     " '!' file or directory is missing and was removed via non-svn command\n"
     " '~' versioned as directory, but is file, or vice versa\n"
     " Second column: Modifications of a file's or directory's properties\n"
- " '_' or ' ' no modifications, 'M' Modified\n"
+ " ' ' no modifications, 'M' Modified\n"
     " Third column: A svn process has a lock in '.svn' for the file or directory\n"
     " ' ' no lock held, 'L' lock being held\n"
     " Fourth column: Scheduled commit will contain addition-with-history\n"
Index: subversion/clients/cmdline/status.c
===================================================================
--- subversion/clients/cmdline/status.c
+++ subversion/clients/cmdline/status.c Thu Oct 17 14:38:06 2002
@@ -33,9 +33,8 @@
 /* Fill in the first four characters of STR_STATUS with status code
    characters, based on TEXT_STATUS, PROP_STATUS, LOCKED, and COPIED.
 
- This function is also used by commit-cmd.c
 */
-void
+static void
 svn_cl__generate_status_codes (char *str_status,
                                enum svn_wc_status_kind text_status,
                                enum svn_wc_status_kind prop_status,
@@ -85,10 +84,8 @@
   switch (prop_status)
     {
     case svn_wc_status_none:
- prop_statuschar = ' ';
- break;
     case svn_wc_status_normal:
- prop_statuschar = '_';
+ prop_statuschar = ' ';
       break;
     case svn_wc_status_added:
       prop_statuschar = 'A';

-- 
andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org