[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "M_" in status

From: Andreas J. Koenig <andreas.koenig_at_anima.de>
Date: 2002-10-17 10:16:20 CEST

>>>>> On Thu, 17 Oct 2002 00:35:03 -0500, "B. W. Fitzpatrick" <fitz@red-bean.com> said:

> andreas.koenig@anima.de (Andreas J. Koenig) writes:
>> Since I made changes in my working copy of svn I get some "M_" in the
>> first column of the output of the status command:
>>
>> svn status -u
>> M 3380 Makefile.in
>> M_ 3380 doc/handbook/appendices.texi
>> M_ 3380 doc/handbook/client.texi
>> M_ 3380 doc/handbook/getting_started.texi
>> M_ 3380 doc/handbook/repos_admin.texi
>> Head revision: 3380
>>
>>
>> This looks like a bug or maybe an undocumented feature, at least as an
>> inconsistency. What else could it be?

> This was a decision made a loooooooong time ago that, IMO, should be
> changed. The point was that CVS users didn't know about properties,
> so when they modified a file, we'd show an underbar if the file had
> properties--even if the properties weren't modified.

> So if you do a proplist on the file in question:

> pantheon:~/svn-work/subversion/$ svn proplist doc/handbook/repos_admin.texi
> Properties on 'doc/handbook/repos_admin.texi':
> svn:eol-style

> You'll see that it has a property set. Does that make sense?

I have no preference either way, it's just a matter of documentation.

> Anyway, if you wouldn't mind submitting a patch to eliminate that, I'll
> be glad to commit it if no one has any objections.

This would seem to do it:

Index: subversion/clients/cmdline/main.c
===================================================================
--- subversion/clients/cmdline/main.c
+++ subversion/clients/cmdline/main.c Thu Oct 17 10:05:13 2002
@@ -383,7 +383,7 @@
     " '!' file or directory is missing and was removed via non-svn command\n"
     " '~' versioned as directory, but is file, or vice versa\n"
     " Second column: Modifications of a file's or directory's properties\n"
- " '_' or ' ' no modifications, 'M' Modified\n"
+ " ' ' no modifications, 'M' Modified\n"
     " Third column: A svn process has a lock in '.svn' for the file or directory\n"
     " ' ' no lock held, 'L' lock being held\n"
     " Fourth column: Scheduled commit will contain addition-with-history\n"
Index: subversion/clients/cmdline/status.c
===================================================================
--- subversion/clients/cmdline/status.c
+++ subversion/clients/cmdline/status.c Thu Oct 17 09:39:21 2002
@@ -85,10 +85,8 @@
   switch (prop_status)
     {
     case svn_wc_status_none:
- prop_statuschar = ' ';
- break;
     case svn_wc_status_normal:
- prop_statuschar = '_';
+ prop_statuschar = ' ';
       break;
     case svn_wc_status_added:
       prop_statuschar = 'A';

-- 
andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 17 10:17:24 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.