[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pre-commit hooks modifying transaction (Was: "svn branch" and "svn label")

From: Noel Yap <yap_noel_at_yahoo.com>
Date: 2002-10-16 12:22:57 CEST

--- Karl Fogel <kfogel@newton.ch.collab.net> wrote:
> > Or, would the problem be that the working
> directory
> > thinks it has checked in say, revision 5, when, in
> > fact, the real revision 5 has other stuff that was
> > tacked on by the pre-commit hook?
>
> Right, that's the problem.

It just occurred to me that what I had in mind will
not modify anything that the user will have checked
out.

For example, if the user were working in
/project/main/HEAD and checks in for the first time as
revision 5, stuff that the hooks will modify will
include:
/project/main # property will be modified
/project/main/1 # cp of /project/main/HEAD -r 5

The other stuff the hooks will do don't involve
working directories since they'll act on cp and mkdir
commands with URL arguments.

Can anyone think of anything else that may be
dangerous when modifying transactions from within
pre-commit hooks?

Thanks,
Noel

__________________________________________________
Do you Yahoo!?
Faith Hill - Exclusive Performances, Videos & More
http://faith.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 16 12:23:38 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.