Nuutti Kotivuori wrote:
>I'm wonder how to proceed on this. As per previous discussion, the
>configuration support for the user-definable part of the date was
>planned after the config file support was there.
>
>So now it is - and it's time to do the date customization. Just that I
>wonder, how?
>
>The function to do conversion to a human representable date is
>'svn_time_to_human_nts'. It lives in libsvn_subr. It needs to somehow
>get the configuration option that specifies how the date should
>look. There's three places atleast where this is called from - the
>command line client, svnadmin and svnlook. The command line client is
>the most important - I do not know if svnadmin and svnlook should even
>use the configuration file.
>
>So, where should parsing happen and how should the results be passed
>to the function?
>
>My first idea would be to just read in the config file when entering
>the log parsing routine, passing the option in the baton for the log
>display function - and then passing it on to svn_time_to_human_nts
>somehow and being done with it. But maybe there's a better way?
>
>
We're fairly screwed by not having a context parameter in the public
API. That means we can't pass configuration data down the call chain,
among other things (such a beast would be ideal for cancellation
processing, too...). We're reading and parsing the config files multiple
times already, which is bad.
So, how about adding a context parameter to every function? I know
that's a big change, but I think we'll be forced to do that sooner or
later anyway.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 6 18:42:35 2002