[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [updated] [Issue 870] import should set svn:executable automatically

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-09-30 00:32:41 CEST

Brian Denny wrote:

>Another try, including tests this time!
>
>As far as testing import, I followed Branko's suggestion to set one
>of the greek files (in the original greek_state) executable before
>import (in the setup code). This affected some of the other (existing)
>tests.
>
>Specifically, people who write client tests should note that instead
>of writing
> expected_disk = svntest.main.greek_state.copy()
>
>you should now write
> expected_disk = svntest.actions.get_virginal_disk(1) # if checking props
>or
> expected_disk = svntest.actions.get_virginal_disk() # if not
>
>Any objections to this way of doing things? Wrapping my head around
>the test code has been harder than writing the fix in the first place,
>so i won't take offense if you think i should do the test some other
>way.
>
>
Doesn't that simply mean that the greek state should encapsulate
executableness somehow? Changing these calls will just make the tests
slower.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 30 00:33:19 2002

This is an archived mail posted to the Subversion Dev mailing list.