[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 906] New - failed commit does not remove txn in the repo

From: <cmpilato_at_collab.net>
Date: 2002-09-27 15:09:51 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> > + When a commit fails for any reason, the transaction it created in the
> > + repository is not removed. This means that the repository
> > + administrator must use svnadmin to remove stale transactions periodically.
> > +
> > + The XFAIL test for this issue is commit_tests.py 24.
>
> Why do you make such a sweeping statement, Brane?
>
> I'm surprised, because we call txn_abort() all over the place in our
> code, if any kind of svn_error_t is thrown at any point during a
> commit. This is a really old feature that we wrote in the beginning,
> and tested a lot. If we've regressed, I'm amazed. I'll check out
> your new xfail test.

Heh -- wasn't it just a few days ago that you and I were rescuing lost
log messages from their non-aborted txns when people's commits failed
(gstein's in my case, and then someone else you assisted) ? So, you
shouldn't be *too* surprised.

Brane, was that blanket statement accurate? Is this a
commits-over-DAV only thing, or ... help us understand the scope of
the problem, please.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 27 15:11:00 2002

This is an archived mail posted to the Subversion Dev mailing list.