[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: updated [PATCH] [Issue 870] import should set svn:executable automatically

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-09-27 13:03:22 CEST

Brian Denny wrote:

>This version of the patch incorporates several of the ideas/requests
>put forth on this list.
>Tests are still absent. (Working on it; have some specific questions
>which will go in a separate e-mail).
>Also, I haven't exercised this code on Windows as I am not yet set up
>to build there. What it *should* do on Windows is: nothing different
>from before (i.e., do not set svn:executable automatically).

This patch looks quite nice and correct. I'd cange the body of
svn_io_is_file_executable a bit, something like this:

#if defined(APR_HAS_USER) && !defined(SVN_WIN32)
  <all the stuff that's conditional now>
  *executable = FALSE;
  return SVN_NON_ERROR;

The less #ifdefs there are, the better I like it. :-) Otherwise I think it's cool.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 27 13:04:39 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.