[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r3205 cvs2svn broken?

From: Alex Zepeda <zipzippy_at_sonic.net>
Date: 2002-09-24 12:32:43 CEST

Argh, that was the wrong function. Anyways if I insert:

const char **

into svn_fs.i, in its monster list of OUTPARAMs (line 38), it works.
This seems a bit weird to me as const char ** is already defined as an
OUTPARAM later on. I somehow doubt that this is the right solution (could
it be the mysterious abort trap that python fell into just now?).

Importing rcsparse.py wouldn't be a half bad idea either. The appropiate
diff is:

===================================================================
RCS file: /cvsroot/viewcvs/viewcvs/lib/Attic/rcsparse.py,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- viewcvs/viewcvs/lib/Attic/rcsparse.py 2002/02/01 03:43:56 1.14
+++ viewcvs/viewcvs/lib/Attic/rcsparse.py 2002/06/07 06:07:30 1.15
@@ -22,6 +22,7 @@
 
 import string
 import time
+import calendar
 
 
 class _TokenStream:
@@ -541,9 +542,17 @@
       # Convert date into timestamp
       date_fields = string.split(date, '.') + ['0', '0', '0']
       date_fields = map(string.atoi, date_fields)
- if date_fields[0] < 100:
- date_fields[0] = date_fields[0] + 1900
- timestamp = time.mktime(tuple(date_fields))
+ # need to make the date four digits for timegm
+ EPOCH = 1970
+ if date_fields[0] < EPOCH:
+ if date_fields[0] < 70:
+ date_fields[0] = date_fields[0] + 2000
+ else:
+ date_fields[0] = date_fields[0] + 1900
+ if date_fields[0] < EPOCH:
+ raise ValueError, 'invalid year'
+
+ timestamp = calendar.timegm(tuple(date_fields))
 
       # Parse author
       semi, author, sym = self.ts.mget(3)

With this, cvs2svn looks like it will get thru at least the first three
stages of kdelibs. I'll leave it on overnight to see if it'll finish.

- alex

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 24 12:33:51 2002

This is an archived mail posted to the Subversion Dev mailing list.